Deprecate s3 keys unchanged sensor async #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
requested review from
phanikumv,
pankajastro,
pankajkoti,
sunank200,
utkarsharma2 and
vatsrahul1001
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1398 +/- ##
==========================================
- Coverage 98.41% 98.40% -0.02%
==========================================
Files 91 91
Lines 5312 5268 -44
==========================================
- Hits 5228 5184 -44
Misses 84 84 ☔ View full report in Codecov by Sentry. |
|
It has been tested on astro cloud with amazon == 8.15.0 |
1 similar comment
|
It has been tested on astro cloud with amazon == 8.15.0 |
Lee-W
force-pushed
the
deprecate-S3KeysUnchangedSensorAsync
branch
from
01aff99 to
08e32a7
Compare
for more information, see https://pre-commit.ci
This was referenced Jan 3, 2024
pankajkoti
reviewed
Jan 11, 2024
yep, let me remove it in another PR |
sometimes people use hook implementation in taskflow API so wondering if we remove hook code then need a major release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is blocked by the release of
apache/airflow#36363apache/airflow#36467upgrade minimum apache-airflow-providers-amazon to 8.15.0 and deprecate S3KeysUnchangedSensorAsync