Avoid liblzma-dev system dep in uv-dev and uv-bench
#9933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstin
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
| @@ -152,8 +152,6 @@ jobs: | |||
| - uses: Swatinem/rust-cache@v2 | |||
| with: | |||
| save-if: ${{ github.ref == 'refs/heads/main' }} | |||
| - name: "Install system dependencies" | |||
| run: sudo apt-get install liblzma-dev | |||
There was a problem hiding this comment.
We should also remove this from the benchmark job.
|
It's part of the performance features currently, maybe that's why? (We can move it to a new default feature if it's a problem for the distro people) |
konstin
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
|
Oh yeah, can you hook |
|
Rather than adding this everywhere. |
konstin
changed the title
liblzma-dev system dep with static crateliblzma-dev system dep with static crate in uv-dev
konstin
force-pushed
the
konsti/static-lzma
branch
3 times, most recently
from
7c6f76c to
27add41
Compare
konstin
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
charliermarsh
approved these changes
Dec 17, 2024
Enable `lzma-sys/static` through the performance feature in uv-dev too, to avoid the system dependency on `liblzma-dev`.
konstin
force-pushed
the
konsti/static-lzma
branch
from
27add41 to
ac108aa
Compare
konstin
changed the title
liblzma-dev system dep with static crate in uv-devliblzma-dev system dep in uv-dev and uv-bench
konstin
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
konstin
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
lzma-sys/staticthrough the performance feature not only in uv, but in uv-dev and uv-bench too, to avoid the system dependency onliblzma-dev.Ref #9880