Add release workflow #961
Merged
Add release workflow #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Jan 18, 2024
| build-backend = "maturin" | ||
|
|
||
| [project] | ||
| name = "puffin-alpha" |
There was a problem hiding this comment.
So this would publish a binary named puffin to the PyPI package puffin-alpha. (puffin is taken, and it doesn't really matter what we use in the interim.)
charliermarsh
commented
Jan 18, 2024
| @@ -0,0 +1,220 @@ | |||
| # Copyright 2022-2023, axodotdev | |||
charliermarsh
commented
Jan 18, 2024
pyproject.toml
Outdated
| requires-python = ">=3.7" | ||
| keywords = [] | ||
| classifiers = [] | ||
| urls = {} |
There was a problem hiding this comment.
If we want to publish this (stealthily) to PyPI, we need to remove the URLs and authors from the Cargo.toml (they're picked up by Maturin).
charliermarsh
force-pushed
the
charlie/release
branch
2 times, most recently
from
24b16d6 to
e5f0647
Compare
|
I created an alt for PyPI to publish under: https://pypi.org/user/whiskeyjack/. Do folks think it's worth publishing? I suspect it is. |
charliermarsh
force-pushed
the
charlie/release
branch
from
e5f0647 to
85d3701
Compare
charliermarsh
commented
Jan 18, 2024
| with: | ||
| python-version: ${{ env.PYTHON_VERSION }} | ||
| - name: "Prep README.md" | ||
| run: echo "# Puffin" > README.md |
There was a problem hiding this comment.
Intentionally omitting the README for stealthy PyPI.
charliermarsh
added
the
internal
konstin
approved these changes
Jan 18, 2024
|
Sounds great to publish |
charliermarsh
force-pushed
the
charlie/release
branch
5 times, most recently
from
a93daf0 to
ee297ab
Compare
charliermarsh
force-pushed
the
charlie/release
branch
2 times, most recently
from
215fdf5 to
52ffe4b
Compare
This reverts commit a348347.
charliermarsh
force-pushed
the
charlie/release
branch
from
52ffe4b to
410fc5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a release workflow powered by
cargo-dist. It's similar to the version that's PR'd in Ruff (astral-sh/ruff#9559), with the exception that it doesn't include the Docker build or the "update dependents" step for pre-commit.