Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install managed Python into the Windows Registry (PEP 514) #10634
base: main
Are you sure you want to change the base?
Install managed Python into the Windows Registry (PEP 514) #10634
Changes from all commits
ed056d1
e46269a
6d1bbde
21a0e3c
016f80f
ba15ae8
e4833a9
7d3a10b
234ade9
a7c1954
1c1e090
c8a9fde
0bb4777
98225cc
982530c
6fcb898
415b276
6bc0a1f
5f8a3ec
478b85d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is adding this bool here just for this one use?
It makes me a little sad to need to pass
false
everywhere. Unfortunately the logic here is fairly involved... hm.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bailed on rewriting the entire logic here, not sure either.