Warn-and-ignore for unsupported requirements.txt options
#10420
Merged
+135
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
error messages
charliermarsh
force-pushed
the
charlie/warn-ignore
branch
from
2fda1f0 to
496e6a9
Compare
konstin
approved these changes
Jan 9, 2025
Gankra
approved these changes
Jan 9, 2025
| iniconfig | ||
| "})?; | ||
|
|
||
| uv_snapshot!(context.pip_install() |
There was a problem hiding this comment.
ooh neat, i hadn't noticed y'all using the inline snapshot magic yet
There was a problem hiding this comment.
It can always use some love if you're interested :)
charliermarsh
force-pushed
the
charlie/warn-ignore
branch
from
496e6a9 to
9ea0a22
Compare
charliermarsh
force-pushed
the
charlie/warn-ignore
branch
from
9ea0a22 to
51e4629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #10366.