Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tool list output when tool environment is broken #10409

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

blueraft
Copy link
Contributor

@blueraft blueraft commented Jan 8, 2025

Summary

Closes #9579

Test Plan

cargo test

Screenshot 2025-01-08 at 21 13 11

@zanieb zanieb self-assigned this Jan 8, 2025
if let uv_tool::Error::EnvironmentError(e) = e {
warn_user!(
"{e} (run `{}` to remove)",
format!("uv tool uninstall {name}").green()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to suggest reinstall instead of uninstall, right? Does it work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that seems better. it worked for me!

@zanieb zanieb added the bug Something isn't working label Jan 9, 2025
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zanieb zanieb merged commit 452cafc into astral-sh:main Jan 9, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve tool list output when tool interpreter is missing
2 participants