Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Docker rate limits by logging into DockerHub #10400

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jan 8, 2025

The latest release flaked failing to fetch the buildx image, which is reportedly due to rate limits. Last I checked, DockerHub enforces much stricter limits on unauthenticated requests. I added a bot account and a corresponding read-only token.

@zanieb zanieb added the internal A refactor or improvement that is not user-facing label Jan 8, 2025
@zanieb zanieb marked this pull request as ready for review January 8, 2025 17:07
Copy link
Contributor

@Gankra Gankra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you intentionally skip the docker-publish task on L108?

@zanieb
Copy link
Member Author

zanieb commented Jan 8, 2025

Nope! Good catch, thanks :)

@zanieb zanieb enabled auto-merge (squash) January 8, 2025 18:23
@zanieb zanieb merged commit 68bfa5b into main Jan 8, 2025
69 checks passed
@zanieb zanieb deleted the zb/docker-rate branch January 8, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants