Improve file pinning comments #10387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not ideal still but it captures the reason why the code is the way it is. Ideally we should remove file pins as it exists now entirely, we're doing a expensive clone (it's noticeable in profiles) of a type that we can still retrieve later only to discard most of them after the resolution is done; But that's out of scope for now.
konstin
force-pushed
the
konsti/file-pins-comment
branch
from
c1c65b0 to
62959ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ideal still but it captures the reason why the code is the way it is.
Ideally we should remove file pins as it exists now entirely, we're doing a expensive clone (it's noticeable in profiles) of a type that we can still retrieve later only to discard most of them after the resolution is done; But that's out of scope for now.