Re-enable zlib-ng on all platforms (except s390x, PowerPC, and FreeBSD) #10370
+45
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/zlib-ng
branch
from
d9ce6fc to
85d8a69
Compare
charliermarsh
force-pushed
the
charlie/zlib-ng
branch
from
b1e3158 to
76611a1
Compare
charliermarsh
changed the title
charliermarsh
changed the title
|
@Gankra may also find this interesting. |
Gankra
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PowerPC seems to build without errors if we upgrade
zlib-ng, but upgradingzlib-ngcauses Windows to break (rust-lang/libz-sys#225), and Cargo doesn't let us include two different versions.s390x fails because it can't find
stfle. It's possible that we could fix this by by upgrading our manylinux version and/or by upgrading GCC (which may necessitate upgrading our manylinux version), but I don't know if it's fixable without one of those things? And it's not worth bumping compatibility for that reason. \cc @konstin