Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate tracing for choose version #10351

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

konstin
Copy link
Member

@konstin konstin commented Jan 7, 2025

Ref #10344

This trace is crucial to understanding the tracing-durations-export diagrams, but it took ~5% resolver thread runtime for apache-airflow (profiling information). It looks neutral in hyperfine (below noise threshold)

This trace is crucial to understanding the tracing-durations-export diagrams, but it took ~5% resolver thread runtime for apache-airflow (profiling information).

```
$ hyperfine --warmup 2 --runs 50 "./uv-7 pip compile scripts/requirements/airflow.in" "target/profiling/uv pip compile scripts/requirements/airflow.in"
  Benchmark 1: ./uv-7 pip compile scripts/requirements/airflow.in
    Time (mean ± σ):     225.0 ms ±   5.4 ms    [User: 310.8 ms, System: 124.6 ms]
    Range (min … max):   218.3 ms … 240.4 ms    50 runs

  Benchmark 2: target/profiling/uv pip compile scripts/requirements/airflow.in
    Time (mean ± σ):     216.0 ms ±   5.8 ms    [User: 299.1 ms, System: 125.7 ms]
    Range (min … max):   209.8 ms … 241.7 ms    50 runs

  Summary
    target/profiling/uv pip compile scripts/requirements/airflow.in ran
      1.04 ± 0.04 times faster than ./uv-7 pip compile scripts/requirements/airflow.in
```
@konstin konstin added the performance Potential performance improvement label Jan 7, 2025
@konstin konstin enabled auto-merge (squash) January 7, 2025 09:44
@konstin konstin merged commit 180a138 into main Jan 7, 2025
54 checks passed
@konstin konstin deleted the konsti/dont-trace-hottest-functions branch January 7, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Potential performance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant