Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify build system specific features usage. #10261

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

FishAlchemist
Copy link
Contributor

@FishAlchemist FishAlchemist commented Jan 1, 2025

Summary

Since there are occasional inquiries about how to configure UV for build-system specific features, I want to raise awareness that users should refer to the documentation of the build system they are using for relevant settings.

Test Plan

Run docs service in local.
9821d58
image

@FishAlchemist
Copy link
Contributor Author

FishAlchemist commented Jan 1, 2025

However, if you have a better approach, please feel free to add a suggestion or create a separate pull request. If you think this is unnecessary, you can close this pull request directly.

If we require certain files to be included, we'll need to read the setuptools documentation for configuration options.

@charliermarsh charliermarsh requested a review from zanieb January 1, 2025 19:53
@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Jan 1, 2025
@zanieb zanieb self-assigned this Jan 8, 2025
@zanieb
Copy link
Member

zanieb commented Jan 8, 2025

Thanks!

I pushed 859b6b0 to give this some dedicated space

Is there more we should add here? I'm sure the bullets are not exhaustive as is. cc @konstin

@konstin
Copy link
Member

konstin commented Jan 9, 2025

There's also:

  • dynamic metadata
  • native code compilation
  • partially: shared library vendoring/glibc compatibility/auditwheel (maturin integrates it, other backends expect the user to run auditwheel).

@zanieb zanieb enabled auto-merge (squash) January 9, 2025 14:39
auto-merge was automatically disabled January 9, 2025 15:15

Head branch was pushed to by a user without write access

@FishAlchemist FishAlchemist force-pushed the supplementary_build-system branch from 10a8c1a to 100c9cf Compare January 9, 2025 15:15
@FishAlchemist
Copy link
Contributor Author

FishAlchemist commented Jan 9, 2025

I just synced with main (git rebase main), but I don't know how to turn off signing commits.
By the way, have we considered running the uvx ruff version in CI? Because I really can't reproduce the error.

@FishAlchemist
Copy link
Contributor Author

The issue seems to be related to ruff 0.9.0's handling of f-string expressions.

@konstin
Copy link
Member

konstin commented Jan 9, 2025

The error is not your fault, it's unrelated to your PR. The ruff 0.9 upgrade broke uv CI because uv CI doesn't pin ruff and it's getting fixed in #10433. Once that is merged we can rebase this PR on main and merge.

@FishAlchemist FishAlchemist force-pushed the supplementary_build-system branch from 100c9cf to 9821d58 Compare January 9, 2025 16:15
@zanieb zanieb merged commit 201726c into astral-sh:main Jan 9, 2025
53 checks passed
@FishAlchemist FishAlchemist deleted the supplementary_build-system branch January 9, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants