Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[red-knot] Upgrade salsa to include AtomicPtr perf improvement #16398

Merged
merged 1 commit into from
Feb 26, 2025
Merged

[red-knot] Upgrade salsa to include AtomicPtr perf improvement #16398

merged 1 commit into from
Feb 26, 2025
+5 −12

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Feb 26, 2025 •
edited
Loading

Summary

Pulling in @ibraheemdev's perf improvement to use AtomicPtr in salsa

salsa-rs/salsa#737

@MichaReiser MichaReiser added the red-knot Multi-file analysis & type inference label Feb 26, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 26, 2025

CodSpeed Performance Report

Merging #16398 will improve performances by 8.96%

Comparing micha/update-salsa-atomic-ptr (538964f) with main (dd6f623)

Summary

⚡ 1 improvements
✅ 31 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ red_knot_check_file[incremental] 6 ms 5.5 ms +8.96%

@MichaReiser
Copy link
Member Author

Nice

@MichaReiser MichaReiser added the performance Potential performance improvement label Feb 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@MichaReiser MichaReiser merged commit c892fee into main Feb 26, 2025
21 checks passed
@MichaReiser MichaReiser deleted the micha/update-salsa-atomic-ptr branch February 26, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
performance Potential performance improvement red-knot Multi-file analysis & type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaReiser @AlexWaygood