[red-knot] Add AlwaysTruthy and AlwaysFalsy to knot_extensions
#15437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InSyncWithFoo
requested review from
carljm,
MichaReiser,
AlexWaygood and
sharkdp
as code owners
|
sharkdp
reviewed
Jan 12, 2025
There was a problem hiding this comment.
Thank you. Adding AlwaysTruthy and AlwaysFalsy seems sensible to me. I considered adding something like LiteralExt in the knot_extensions PR, but we then decided to go with the more general TypeOf for now. If we add LiteralExt, we should probably remove TypeOf?
AlexWaygood
reviewed
Jan 12, 2025
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
reviewed
Jan 12, 2025
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
approved these changes
Jan 12, 2025
InSyncWithFoo
changed the title
knot_extensions with a few more symbolsAlwaysTruthy and AlwaysFalsy to knot_extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #15397. There are quite a few tests that use
AlwaysTruthy/AlwaysFalsy/ClassLiteral/FunctionLiteral, so it's would be convenient to have direct access to them viaknot_extensions.Test Plan
Markdown tests.