Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] initial fixpoint iteration #14029

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[WIP] initial fixpoint iteration #14029

wants to merge 5 commits into from

Conversation

carljm
Copy link
Contributor

@carljm carljm commented Nov 1, 2024

Pulls in a Salsa version that supports fixpoint iteration, for experimentation.

@carljm carljm added the red-knot Multi-file analysis & type inference label Nov 1, 2024
Copy link

codspeed-hq bot commented Nov 1, 2024

CodSpeed Performance Report

Merging #14029 will degrade performances by 11.21%

Comparing cjm/fixpoint (3189bd8) with main (b89d61b)

Summary

❌ 1 regressions
✅ 31 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
red_knot_check_file[incremental] 5.5 ms 6.2 ms -11.21%

Copy link
Contributor

github-actions bot commented Nov 1, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@MichaReiser
Copy link
Member

Nice on bringing down the regression. I'm still somewhat surprised that we see an 11% perf regression and a 4 perf regression in the salsa benchmarks (that don't have any cycles).

@carljm
Copy link
Contributor Author

carljm commented Nov 15, 2024

Yeah I planned to do some more looking at profiles; thanks for doing that!

@carljm carljm force-pushed the cjm/fixpoint branch 5 times, most recently from 331f3de to 5048b31 Compare February 25, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants