Normalize source indentation #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the slow feedback, @Bananeweizen!
You mean that: could become: right? I tink it would make sense to cleanup unnecessary configurations together with the introduction of the global flag. Would you have time for it? Otherwise, we can take it over. |
The AssertJ source blocks are taken from real code, which is indented as usual in an IDE. To avoid the source snippets use that (somewhat random) indentation in the documentation afterwards, the indentation of each source block needs to be set to zero. While that is currently done on each block separately, it is less error-prone by using the globally available attribute.
The indentation attribute is now set globally, therefore it is not needed anymore at each source block.
Bananeweizen
force-pushed
the
normalize_indentation
branch
from
8155460 to
ca4f844
Compare
|
@scordio Yes, that's exactly what I meant. I've rebased and added a second commit for the cleanup. Feel free to squash or otherwise change. |
|
Thanks, @Bananeweizen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AssertJ source blocks are taken from real code, which is indented as usual in an IDE. To avoid the source snippets use that (somewhat random) indentation in the documentation afterwards, the indentation of each source block needs to be set to zero.
While that is currently done on each block separately, it is less error-prone by using the globally available attribute.
Be aware I have not been able to build this locally due to a restrictive company proxy setup, but I'm using the same setting in another Maven based project, and it works well.