-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
207 menu button color #208
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2646754
move the default theme colors into a module.scss file
alishaevn 4ebd693
use an editable svg as the navbar toggle icon
alishaevn a4e7d04
adjust navbar toggle behavior
alishaevn 6ae2844
slight refactor of ToggleIcon
alishaevn e06e290
Merge branch 'main' into 207-menu-button-color
alishaevn 69afdc2
overriding the spread radius for ".navbar-toggler:focus"
alishaevn 6639c6c
more accurate propType definition of Header.linkColor
alishaevn 8c27059
revert the Navbar.Brand to only 50% width
alishaevn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import * as React from 'react' | ||
import themeColors from '../theme/default-colors.module.scss' | ||
|
||
const ToggleIcon = ({ linkColor }, props) => ( | ||
<svg | ||
xmlns='http://www.w3.org/2000/svg' | ||
xmlSpace='preserve' | ||
style={{ | ||
enableBackground: 'new 0 0 227 163.3', | ||
}} | ||
viewBox='0 0 227 163.3' | ||
fill={themeColors[linkColor]} | ||
width={25} | ||
height={25} | ||
{...props} | ||
> | ||
<path d='M113.1 33h-95C5.8 33-2.1 22.1 2.2 11.3 4.6 5.2 9.3 1.8 15.8 1.1c1.5-.2 3-.1 4.5-.1h185.5c2.2 0 4.4-.1 6.5.3 8.1 1.6 13.6 9.2 12.7 17.2-.8 8.1-7.5 14.3-15.9 14.3-21 .1-42 0-63 .1-11 .1-22 .1-33 .1zM113 65h95c12.7 0 20.7 11.7 15.6 22.6-3.1 6.6-8.5 9.4-15.7 9.4H18.4C5.8 97-2.2 86 2.2 75.1c2.6-6.4 8.3-10 16.3-10.1H113zM113.3 129c31.7 0 63.3-.1 95 0 13.2 0 21.1 13.3 14.5 24.1-3.5 5.8-9 7.9-15.7 7.9-45.8-.1-91.7 0-137.5 0H19.1c-10.7 0-17.9-6.4-18-15.9C1 135.5 8.3 129 19.3 129h94z' /> | ||
</svg> | ||
) | ||
|
||
export default ToggleIcon |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
/** | ||
* This file contains the color variables for the theme. Matching those in each webstore instance's "theme.module.scss" file. | ||
* | ||
* They exist in a "module.scss" file so that they can be imported into our ".scss" AND ".jsx" files. | ||
*/ | ||
$primary: #614570; | ||
$secondary: #936AAA; | ||
$light: #F2F2F2; | ||
$dark: #070818; | ||
$success: #B0E298; | ||
$info: #8eb3fc; | ||
$warning: #E9DF00; | ||
$danger: #D20000; | ||
$black: #000000; | ||
$white: #FFFFFF; | ||
|
||
:export { | ||
primary: $primary; | ||
secondary: $secondary; | ||
success: $success; | ||
info: $info; | ||
warning: $warning; | ||
danger: $danger; | ||
light: $light; | ||
dark: $dark; | ||
black: $black; | ||
white: $white; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fixes the changed media query after changing the toggle icon.
ref: this commit for more details.