Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring the _types target (when alias) has the right tags #770

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

menny
Copy link
Contributor

@menny menny commented Feb 6, 2025

When using the alias variant of the _types (dedicated dts_emitter) the target will not be given the provided tags, unlike all the other targets generated by this macro, including the _types when created using the filegroup.


Changes are visible to end-users: yes/no

no

Test plan

bazel query //:target_types --output=xml will show that the tags attribute was set correctly.

Copy link

aspect-workflows bot commented Feb 6, 2025

Test

All tests were cache hits

163 tests (100.0%) were fully cached saving 16s.


Format

Formatting check has failed

💡 Some formatting failures can be fixed automatically by running the command below, while others may require manual fixes

bazel run //:format

Buildifier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant