Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planar projection camera #504

Conversation

thatcomputerguy0101
Copy link
Contributor

This adds the surface-level API for utilizing the planar projection introduced in asny/three-d-asset#42, and modifies the camera_view example of #501 to support the new camera mode. See each of those respective PRs for more details.

@asny
Copy link
Owner

asny commented Nov 20, 2024

I have released a three-d-asset version with the planar projection camera. Is everything still working as expected with that released version? Also, did you plan to get the example in? I like the functionality but it's a really really long example, can you simplify it?

@asny
Copy link
Owner

asny commented Nov 21, 2024

I've added the Camera::new_planar function, I guess that is the only difference between this and #501? So I guess this can be closed? Also, I plan to do a release soon, but since the examples are not part of the release anyway, there's no rush getting that merged.

@thatcomputerguy0101
Copy link
Contributor Author

Yes, 4bdd442 was the only commit from this pr on the main library, while the rest all focused on the examples. I'll transfer over d6045b0 to #501, as that was the update to the example to support the planar camera.

Regarding simplification, I'm removing the shapes and only including the axis arrows. However, removing anything else probably reduces the utility of the example as a debug tool. There is a lot of complexity in computing the view frustum outlines, but simplifying that while keeping the same result is difficult.

@thatcomputerguy0101
Copy link
Contributor Author

#501 is now updated with planar support, so I'm closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants