Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Variants page responsive. #412

Merged
merged 2 commits into from
Nov 9, 2024
Merged

Conversation

Ibrangrd
Copy link
Contributor

@Ibrangrd Ibrangrd commented Nov 8, 2024

Make Variants page responsive.
Also fix the navbaar and also make it responsive.
Screenshot 2024-11-08 234639

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stark-tech-portfolio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 8:55am

Copy link
Owner

@aslams2020 aslams2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed so much of code from variants.css
Is there is a reason for that?

@Ibrangrd
Copy link
Contributor Author

Ibrangrd commented Nov 9, 2024

Yes, I removed extra code because each variant used the same CSS styling. Instead of repeating the same styles, I created one shared class with those styles and applied it to all variants. Don’t worry—this change doesn’t affect your variant page. It actually improves readability, and I’ll upload some pictures from my local setup to show that everything still looks the same.
Uploading Screenshot 2024-11-09 141844.png…

@aslams2020 aslams2020 added gssoc-ext Indicates Contributions made to GSSoC Extended'24 level1 labels Nov 9, 2024
@aslams2020 aslams2020 merged commit 014b77d into aslams2020:main Nov 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext Indicates Contributions made to GSSoC Extended'24 level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants