Improvement: generate migrations task support concurrent indexes flag #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pattern match to separate migration when true
… added in separate migration
zachdaniel
reviewed
Jan 31, 2025
| @@ -22,6 +22,7 @@ defmodule Mix.Tasks.AshPostgres.GenerateMigrations do | |||
| * `dry-run` - no files are created, instead the new migration is printed | |||
| * `check` - no files are created, returns an exit(1) code if the current snapshots and resources don't fit | |||
| * `snapshots-only` - no migrations are generated, only snapshots are stored | |||
| * `concurrent-indexes` - new identities will be run in a separate migration (like concurrent custom indexes) | |||
There was a problem hiding this comment.
Suggested change
| * `concurrent-indexes` - new identities will be run in a separate migration (like concurrent custom indexes) | |
| * `concurrent-indexes` - new identities will be run concurrently and in a separate migration (like concurrent custom indexes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#462
Contributor checklist