Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

range object validator support #254

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

SpicyGarlicAlbacoreRoll
Copy link
Contributor

  • allows ranges in search param lists
  • optimizes range when step=1 to use lower and upper bounds when building search opts

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d410a29) 89.87% compared to head (efea8b4) 89.79%.

Files Patch % Lines
asf_search/ASFSearchOptions/validators.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
- Coverage   89.87%   89.79%   -0.09%     
==========================================
  Files          54       54              
  Lines        2025     2028       +3     
==========================================
+ Hits         1820     1821       +1     
- Misses        205      207       +2     
Flag Coverage Δ
unittests 89.79% <66.66%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SpicyGarlicAlbacoreRoll SpicyGarlicAlbacoreRoll marked this pull request as ready for review January 9, 2024 23:05
@SpicyGarlicAlbacoreRoll SpicyGarlicAlbacoreRoll merged commit a5f017e into master Jan 9, 2024
3 checks passed
@SpicyGarlicAlbacoreRoll SpicyGarlicAlbacoreRoll deleted the range-object-validator-support branch January 9, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants