Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm mage #48

Merged
merged 4 commits into from
Jul 12, 2024
Merged

rm mage #48

merged 4 commits into from
Jul 12, 2024

Conversation

gertd
Copy link
Member

@gertd gertd commented Jul 12, 2024

  • Remove mage
  • Add makefile
  • Remove GCP bucket publishing from goreleaser manifest

@gertd gertd requested a review from ronenh July 12, 2024 16:01
@coveralls
Copy link

coveralls commented Jul 12, 2024 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 9911223049

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.863%
Totals Coverage Status
Change from base Build 9911137942: 0.0%
Covered Lines: 2793
Relevant Lines: 4589
💛 - Coveralls

ronenh
ronenh previously approved these changes Jul 12, 2024
View reviewed changes
@gertd gertd dismissed ronenh’s stale review July 12, 2024 16:39

The merge-base changed after approval.

@gertd gertd merged commit 3d5e497 into main Jul 12, 2024
2 checks passed
@gertd gertd deleted the rm-mage branch July 12, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronenh ronenh ronenh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gertd @coveralls @ronenh