Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inversion of subject relations #44

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Fix inversion of subject relations #44

merged 1 commit into from
Apr 10, 2024

Conversation

ronenh
Copy link
Contributor

@ronenh ronenh commented Apr 10, 2024

Information about subject relations wasn't propagated all the way and resulted in the construction of incorrect relation or permission names, which caused validation error due to unresolved references (we were constructing permissions that refer to other permissions which don't exist).

Copy link

Pull Request Test Coverage Report for Build 8639028966

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 60.958%

Totals Coverage Status
Change from base Build 8638251641: 0.04%
Covered Lines: 2762
Relevant Lines: 4531

💛 - Coveralls

@ronenh ronenh requested a review from gertd April 10, 2024 23:19
@gertd gertd merged commit ab12b4f into main Apr 10, 2024
2 checks passed
@gertd gertd deleted the inversion-fix branch April 10, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants