Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract serializer and allow passing extra descriptors #111

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gimmyxd
Copy link
Member

@gimmyxd gimmyxd commented Jan 20, 2025

Allow adding extra descriptors when creating a directory client. The descriptors are added to the registry that is used for message serialization to JSON.
By default the directory client has a registry that knows about all the types in pb-directory. This change allows extending the directory client with the types defined in a separate namespace(eg: pb-directory-store).

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (3066505) to head (fa55bef).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   88.03%   88.07%   +0.03%     
==========================================
  Files          31       31              
  Lines         903      906       +3     
  Branches      257      262       +5     
==========================================
+ Hits          795      798       +3     
+ Misses        108      107       -1     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gimmyxd gimmyxd marked this pull request as ready for review January 20, 2025 09:51
@gimmyxd gimmyxd requested review from ronenh and ogazitt January 20, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants