Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: asdf >= v0.16.0 php install #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkungla
Copy link

@mkungla mkungla commented Feb 3, 2025

Description:

From asdf version v0.16.0, this plugin breaks and fails when trying to install a PHP version. This PR introduces a fix that addresses this issue for asdf >= v0.16.0 while ensuring backward compatibility with older versions of asdf. Specifically, the default value of ASDF_CONCURRENCY as 'auto' breaks the PHP compiler.

Additionally, I recommend the maintainers set up the bin/help.deps script in the repository to define platform-specific dependencies, as detailed in the asdf plugin documentation. This will help list and check missing dependencies before attempting to compile new PHP versions.

Years ago, I faced a similar issue while building my own PHP version manager, which you can find here: howiphp. I encountered the same challenge when listing and verifying missing dependencies prior to compiling PHP versions.


Changes Introduced:

  • Fixes compatibility with asdf v0.16.0 and later versions.
  • Ensures no breaking changes for versions prior to v0.16.0.

Testing:

  • Tested with asdf v0.16.0 and v0.15.0 to verify proper functionality.
  • Maintains compatibility with earlier versions of asdf.

@mkungla mkungla requested a review from a team as a code owner February 3, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant