Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add valid parameter check declaration #23

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

romanodanilo
Copy link
Contributor

Description

Addressing #16 , Add check logic, test files and test code

How was the PR tested?

  1. Unit-test with sample data. All unit tests passed.

Notes

example output

 <Checker status="completed" checkerId="parameters_xosc" description="Check if parameters properties of input file are properly set" summary="">
      <AddressedRule ruleUID="asam.net:xosc:1.2.0:parameters.valid_parameter_declaration_in_catalogs"/>
      <Issue issueId="0" description="Issue flagging when used parameters is not defined or has not default value within a catalog" level="1" ruleUID="asam.net:xosc:1.2.0:parameters.valid_parameter_declaration_in_catalogs">
        <Locations description="Parameter centerBoundingBoxX for attribute x  not defined in Catalog or with no default value">
          <XMLLocation xpath="/OpenSCENARIO/Catalog/Vehicle/BoundingBox/Center"/>
        </Locations>
      </Issue>
    </Checker>

@romanodanilo romanodanilo marked this pull request as ready for review July 10, 2024 07:53
Copy link
Contributor

@hoangtungdinh hoangtungdinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @romanodanilo

@hoangtungdinh hoangtungdinh merged commit ec9dd42 into develop Jul 10, 2024
7 checks passed
@hoangtungdinh hoangtungdinh deleted the danilo/add_first_parameter_check branch July 10, 2024 09:02
hoangtungdinh pushed a commit that referenced this pull request Jul 11, 2024
Signed-off-by: romanodanilo <[email protected]>

Signed-off-by: romanodanilo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants