Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix models search mode to catch all sub-elements occurrences #27

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

patrickpa
Copy link
Contributor

Description

This PR adds a fix for an issue where the models where parsing wrongly the XML files because they were expecting a given order for the elements. With this new implementation the order does not matter anymore and all elements will be parsed.

Main changes

  1. Add search mode unordered to elements with more than one sub-element
  2. Add tests for the order independence of the models

How was the PR tested?

  1. Unit-test with some sample data for order difference.

Notes

  • None.

@patrickpa patrickpa self-assigned this Aug 21, 2024
Copy link
Contributor

@hoangtungdinh hoangtungdinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @patrickpa

@hoangtungdinh hoangtungdinh merged commit 4eee5b2 into develop Aug 21, 2024
7 checks passed
@hoangtungdinh hoangtungdinh deleted the patrick/fix_search_mode branch August 21, 2024 15:32
hoangtungdinh pushed a commit that referenced this pull request Aug 21, 2024
hoangtungdinh pushed a commit that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants