restored Vector.h:isallfinite() logic #299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restored isfinite logic Hi! I was trying to update my branch with Arx master and found that problem. I didn't test too much, but as much I did, everything else look good :)
|
closed in favor of: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I was trying to update my branch with Arx master and found that problem.
I didn't test too much, but as much I did, everything else look good :)
(obs.: I was trying to just create an annotation/blame to call attention to the problem, but I am not very used to some github details. mmm... this could have been just an issue tho...; my commit message ended up wrong because I understood that action in github would create a new pull request comment and not a commit comment and then a pull request... dumb me...; just drop this PR as the modification is minimal :))