-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added extensions for virtual environments in .gitignore #2372
Conversation
This reverts commit 90e649f.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2372 +/- ##
=======================================
Coverage 87.01% 87.01%
=======================================
Files 124 124
Lines 12788 12788
=======================================
Hits 11128 11128
Misses 1660 1660 ☔ View full report in Codecov by Sentry. |
.env | ||
.venv | ||
env/ | ||
venv/ | ||
ENV/ | ||
|
||
# PyInstaller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other options that come to my mind are
hatch.toml
pdm.lock
Pipfile.lock
Pipfile
poetry
.lock`
I'm not completely sure if people should be building ArviZ following an approach different from the recommended one, but people can do whatever they want so it's probably good to have these files/directories listed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I believe it's important to use the recommended approaches. However, when installing dependencies, some may prefer to use a virtual environment. While it’s important to track the core dependency and configuration files like Pipfile, Pipfile.lock, poetry.lock, pdm.lock, and hatch.toml in version control, it’s equally important to ignore files and directories that are specific to individual developers' environments, such as virtual environments. These files are not relevant to other people's builds and can clutter the repository.
If you're looking to
then you may want to add items you want git to ignore from your personal setup in the file I'm not opposed to the addition of the |
Description
.gitigore doesn't have anything about environments in its extensions.
When we try to use a virtual environment to run the whole package locally, if we try to add the files to the repository, the environment files are also being added.
To fix that I have included extensions of the virtual environments
Checklist
📚 Documentation preview 📚: https://arviz--2372.org.readthedocs.build/en/2372/