Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds note on load time #271

Merged
merged 1 commit into from
Apr 2, 2024
Merged

adds note on load time #271

merged 1 commit into from
Apr 2, 2024

Conversation

fredshone
Copy link
Contributor

@fredshone fredshone commented Apr 2, 2024

added comment to workbook as per joss feedback here.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.57%. Comparing base (07813c8) to head (e1a11ae).
Report is 161 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
+ Coverage   86.84%   87.57%   +0.73%     
==========================================
  Files          49       48       -1     
  Lines        5496     5747     +251     
  Branches     1372     1436      +64     
==========================================
+ Hits         4773     5033     +260     
+ Misses        462      445      -17     
- Partials      261      269       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredshone fredshone requested a review from brynpickering April 2, 2024 12:23
@fredshone
Copy link
Contributor Author

@brynpickering no review required - just a single line of text

@fredshone fredshone merged commit ec5ca2e into main Apr 2, 2024
14 checks passed
@fredshone fredshone deleted the joss-review branch April 2, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants