Link to cookiecutter template #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 86.84% 87.51% +0.67%
==========================================
Files 49 48 -1
Lines 5496 5751 +255
Branches 1372 1374 +2
==========================================
+ Hits 4773 5033 +260
+ Misses 462 447 -15
- Partials 261 271 +10 ☔ View full report in Codecov by Sentry. |
|
I've updated dependencies to work with Py3.12. Tests seem to pass (maybe you can try it locally on a windows machine too @Theodore-Chatziioannou? GDAL issues should be solved) and I believe the memory profiling test shows a ~20% drop in peak memory consumption (based on another profile that I have from late Sept. 2023). |
|
install and tests run fine on windows 👍🏻 |
fredshone
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings PAM in line with the latest developments in the cookiecutter template that it effectively spawned.
Main change is moving PAM source code into a
srcdirectory. I know this is something we discussed and dismissed previously @fredshone but work since that time has shown me the benefits of it. I'm now a convert ;)Also added a CI job that will monitor the template and ensure PAM conforms to any changes made on it in future.
Should hopefully make it easier to keep PAM up-to-date.
Checklist
Any checks which are not relevant to the PR can be pre-checked by the PR creator.
All others should be checked by the reviewer(s).
You can add extra checklist items here if required by the PR.