Make mup compatible with Meteor 1.3 #942
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please pull this in, seems to have fixed mup deployment for me when upgrading from Meteor 1.2.1 to 1.3.1. Thanks @m4v3r for the fix! |
|
It's not really 100% official but this is depreciated because they are working diligently to port it to kadirahq/meteor-up and no PRs have been merged here in a long time is it over 40 now? ! Anyway if it isn't redundant in the new version they would welcome it there. |
…. (bash: line 18: cd: ./*: No such file or directory)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does few things:
deploy.shscript to properly re-build binary npm packages on 1.3I understand that mup is currently not actively maintained, but I think it would be nice to make it compatible with 1.3 at least, as there are still some people that rely on this excellent tool.