allow override of docker image #728
Conversation
| @@ -219,6 +219,12 @@ Meteor Up uses Docker to run and manage your app. It uses [MeteorD](https://gith | |||
|
|
|||
| For more information see [`lib/taskLists.js`](https://github.com/arunoda/meteor-up/blob/mupx/lib/taskLists/linux.js). | |||
|
|
|||
| #### Using a custom docker image | |||
|
|
|||
| The default docker image (MeteorD) can be overridden by setting `dockerImage` | |||
There was a problem hiding this comment.
It is mup.json file. Not the settings.json file.
Also, show a code sample on to do it. Just having the dockerImage key is enough.
Also, add a link to to MeteorD
There was a problem hiding this comment.
May be you can link also another document on how to extend MeteorD. May be a blog post of yours.
Anyway, that can be done later.
|
Mention me once you done changes. It's hard to track it otherwise.
|
|
Thanks for the feedback. Will fix this week. |
|
+1 |
|
@arunoda . I addressed your review comments. |
|
@arunoda can you pls accept this pull request? thanks |
|
Looks like this will be the new |
|
It will have that. I'm pretty sure I saw a post in the new still under development version to add custom docker images. |
|
Oh please merge it already |
|
This account in general has been depreciated and mupx has almost been ported to kadirahq. |
|
@MasterJames oh, nice, I wasn't aware of that. Thank you! |
|
very useful PR : @arunoda may you merge it ? |
|
No PRs have been merged here for a very long time. It is considered the stable version partly for that reason. |
Use case:
My meteor app depends on having the graphicsmagick binary installed, so I want to use a docker image, based off meteord, that contains the dependency.