Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upload_id to FinishObjectStagingRequest #114

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

das-Abroxas
Copy link
Contributor

This pull request introduces an extension to the FinishObjectStagingRequest by adding the upload_id field. This extension addresses the issue that an upload id generated for a multipart upload needs to be provided if a user wants to manually signal the completion of a multipart upload to the Aruna Server.

@das-Abroxas das-Abroxas added the enhancement New feature or request label Oct 30, 2024
@das-Abroxas das-Abroxas requested review from St4NNi and lfbrehm October 30, 2024 15:29
@das-Abroxas das-Abroxas self-assigned this Oct 30, 2024
@das-Abroxas das-Abroxas changed the title feat: Add upload_id to FinishObjectStagingRequest Add upload_id to FinishObjectStagingRequest Oct 30, 2024
Copy link
Member

@hansen-maria hansen-maria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@das-Abroxas das-Abroxas merged commit 359ba54 into main Oct 30, 2024
4 checks passed
@das-Abroxas das-Abroxas deleted the feat/multipart-object-finish branch October 30, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants