fix: Fixed gRPC numbering and policy/rule confusions

arunaengine · Feb 22, 2024 · 84dbc6b · 84dbc6b
1 parent b2ce195
commit 84dbc6b
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/aruna/api/storage/services/v2/rules_service.proto b/aruna/api/storage/services/v2/rules_service.proto
@@ -87,7 +87,7 @@ service RulesService {
   rpc CreateRuleBinding(CreateRuleBindingRequest)
     returns (CreateRuleBindingResponse) {
       option (google.api.http) = {
-        post : "/v2/rules/{id}/bindings"
+        post : "/v2/rules/{rule_id}/bindings"
         body : "*"
       };
   }
@@ -100,7 +100,7 @@ service RulesService {
   rpc DeleteRuleBinding(DeleteRuleBindingRequest)
     returns (DeleteRuleBindingResponse) {
       option (google.api.http) = {
-        delete : "/v2/rules/{id}/bindings/{object_id}"
+        delete : "/v2/rules/{rule_id}/bindings/{object_id}"
       };
   }
 }
@@ -122,10 +122,10 @@ message GetRuleRequest {
 
 message Rule {
     string id = 1;
-    string rule = 1;
-    string description = 2;
-    bool public = 3;
-    string owner = 4;
+    string rule = 2;
+    string description = 3;
+    bool public = 4;
+    string owner = 5;
 }
 
 message GetRuleResponse {
@@ -156,19 +156,20 @@ message DeleteRuleRequest {
 message DeleteRuleResponse {}
 
 message CreateRuleBindingRequest {
-    string object_id = 1;
-    bool cascading = 2;
+    string rule_id = 1;
+    string object_id = 2;
+    bool cascading = 3;
 }
 
 message CreateRuleBindingResponse {
-    string policy_id = 1;
+    string rule_id = 1;
     string object_id = 2;
     bool cascading = 3;
 }
 
 message DeleteRuleBindingRequest {
-    string policy_id = 1;
+    string rule_id = 1;
     string object_id = 2;
 }
 
-message DeleteRuleBindingResponse {}
+message DeleteRuleBindingResponse {}