Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bundle and BundleTangent types #234

Merged
merged 11 commits into from
Jul 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-16.04, ubuntu-18.04, ubuntu-20.04]
os: [ubuntu-18.04, ubuntu-20.04]
build_type: [Release, Debug]
compiler: [{
"cc": "gcc",
Expand Down
2 changes: 2 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,8 @@ if(ENABLE_CPPCHECK)
--suppress=unknownMacro:*test/ceres/ceres_test_utils.h
--suppress=constStatement:*examples*
--suppress=unreadVariable:*gtest_se2_autodiff.cpp:101
--suppress=unreadVariable:*bundle_sam.cpp:94
--suppress=unreadVariable:*bundle_sam.cpp:124
# Uncomment the line below to run cppcheck-html
# --output-file=${CMAKE_BINARY_DIR}/cppcheck_results.xml
${CMAKE_SOURCE_DIR}/include
Expand Down
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ At the moment, it provides the groups:
introduced (to the best of knowledge) in this [paper][barrau15].
NOTE: The implementation here differs slightly from
the developments in the [paper][barrau15].
- Bundle<>: allows manipulating a manifold bundle as a single Lie group.
Referred to as a *composite manifold* in Section IV of the
[reference paper](http://arxiv.org/abs/1812.01537).

Other Lie groups can and will be added, contributions are welcome.

Expand Down
14 changes: 13 additions & 1 deletion examples/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,18 @@ set(CXX_11_EXAMPLE_TARGETS
se_2_3_localization
)

if(NOT MSVC)
add_executable(bundle_sam bundle_sam.cpp)

set(CXX_11_EXAMPLE_TARGETS

${CXX_11_EXAMPLE_TARGETS}

# Bundle
bundle_sam
)
endif()

# Link to manif
foreach(target ${CXX_11_EXAMPLE_TARGETS})
target_link_libraries(${target} ${PROJECT_NAME})
Expand All @@ -45,7 +57,7 @@ foreach(target ${CXX_11_EXAMPLE_TARGETS})
target_compile_options(${target} PRIVATE
-Werror=all
-Werror=extra
)
)
endif()

endforeach()
Expand Down
Loading