Merge pull request #186 from artivis/fix/const_data_ptr

Fix missing return in const data()
artivis · Dec 14, 2020 · 3453cf8 · 3453cf8
2 parents f656469 + 2084af3
commit 3453cf8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -7,6 +7,7 @@ on:
   pull_request:
     branches:
       - devel
+  workflow_dispatch:
 
 jobs:
 

diff --git a/include/manif/impl/lie_group_base.h b/include/manif/impl/lie_group_base.h
@@ -391,7 +391,7 @@ template <typename _Derived>
 const typename LieGroupBase<_Derived>::Scalar*
 LieGroupBase<_Derived>::data() const
 {
-  derived().coeffs().data();
+  return derived().coeffs().data();
 }
 
 template <typename _Derived>
-Original file line number
+Diff line change
@@ Expand Up / @@ -7,6 +7,7 @@ on: @@
       pull_request:
         branches:
           - devel
+      workflow_dispatch:
     jobs:
@@ Expand Down @@