-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change preservation tasks from table to cards #1086
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1086 +/- ##
==========================================
+ Coverage 54.69% 54.75% +0.06%
==========================================
Files 105 105
Lines 7696 7696
==========================================
+ Hits 4209 4214 +5
+ Misses 3228 3225 -3
+ Partials 259 257 -2 ☔ View full report in Codecov by Sentry. |
4e72c6f
to
ae565e0
Compare
With @jraddaoui's help I've fixed the problem with the card values breaking out of the card body |
@djjuhasz No idea how many of my suggestions are actually viable in terms of responsiveness within the BS5 framework etc, but I did include some initial suggestions to manage narrow screens on the original ticket, including some mockups. Those included:
Also added a response w some other relevant ideas on the ticket conversation, here Either way, great progress so far! |
@fiver-watson Thank, I missed your mockup and suggestions on how to display cards on a narrow screen. I've responded to your suggestions below:
I think this is a good idea that should be extended to the full width display. I think showing both the start and completed time for each task in the collapsed view is unnecessary and adds extra visual noise. If an operator wants to see the started time for a completed task I think it's reasonable that they click on the card to expand it to get that information.
I think we implemented something like this in AtoM and I think it's a good idea. I'm not sure if eliding the text can be accomplished with pure CSS or if it would require Javascript to implement. Either way, I believe it's possible but I will have to do some reading to figure out how to implement it.
I think we should only show the first line in the collapsed card at all screen widths. |
For overflow/ellipses, check https://getbootstrap.com/docs/5.3/helpers/text-truncation/, we use it in a few places already. |
One easy thing that could also help in small widths, I think the title font size is too big. If we use strong text, it looks better to me with the default font size. |
@jraddaoui unfortunately "text-truncate" doesn't work with |
74b9518
to
9bc6deb
Compare
Hi @djjuhasz, thanks so much for your persistence on this issue (i know UI design stuff can be really finnicky) and for your very helpful thoughts! I am fine with all of your suggestions in your comment above - they make good sense and I agree that they will improve the user experience. Thanks!
This totally makes sense - I guess I just wanted to make sure that regardless of screen width, AT LEAST the first line is shown for errors and warnings, where it's important to be able to get an initial sense of why / what's going on at a glance. In most cases, I think that success messages are not going to be more than 1 line anyway. |
2f680da
to
46a500b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos for taming the eternal dragon of responsive layout! My understanding of this realm is limited, but seems good to me!
Refs #1077 Switch the preservation task list from a table to a list of "cards" to provide better display on small screens and facilitate future work to show detailed logs and error information.
46a500b
to
3491515
Compare
I've switched the preservation tasks over to cards (note: the Bootstrap 5 card syntax has changed from the docs @fiver-watson linked in #1077).
I think the current implementation looks pretty good at desktop screen sizes, e.g:
![Screenshot from 2024-11-29 16-36-18](https://private-user-images.githubusercontent.com/626135/391202187-ea7d8932-3d1f-4a61-a0dd-fef9830ec6cb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDAyNTcsIm5iZiI6MTczOTM5OTk1NywicGF0aCI6Ii82MjYxMzUvMzkxMjAyMTg3LWVhN2Q4OTMyLTNkMWYtNGE2MS1hMGRkLWZlZjk4MzBlYzZjYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQyMjM5MTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yNjVmMjZhOThhMTAzZmY0MzllYzAxNDk1M2FlNDAyNDNhNjE4OGJiMjg0MzkzNGYxOTYwZWQ0ZDcwZWJiOTljJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.pG2Yd3Q16sIHaESIn3e8s5Qn97Oe77mBhfCuIiLhQg8)
But the card "columns" are overflowing on narrow screen widths :(
![Screenshot from 2024-11-29 16-34-13](https://private-user-images.githubusercontent.com/626135/391202217-f0f7f66c-2175-4036-8df7-0454807f2c12.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDAyNTcsIm5iZiI6MTczOTM5OTk1NywicGF0aCI6Ii82MjYxMzUvMzkxMjAyMjE3LWYwZjdmNjZjLTIxNzUtNDAzNi04ZGY3LTA0NTQ4MDdmMmMxMi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQyMjM5MTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05MzVlNjg5ZWI2NzliMmRkOTllZDA3MDgyN2ZhMTNhZTFkOTYzODdmMzE5OWZiMjdkNmZhYjc2ZmI4NTNmZDQ1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.dC10vu6iXCI7tTlai_iAyK9mxbq5iMlHchA7VqqL6_M)
I'll do some more reading on how to fix the overflow problem and maybe @jraddaoui will have some ideas too.