Test AM Vagrant box before publishing it #365
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #364 locally I noticed that the AM vagrant box build finishes successfully but the AM services do not start due to Python 3.9 missing.
The reason is this block in the clean up process:
That expression is too loose and it matches
python3.9-dev
among other important libraries for AM.So, this adds steps to test the Vagrant box created through the
Archivematica Vagrant box
CI workflow.In the commits of the pull request you can see how the new test fails in https://github.com/artefactual-labs/am-packbuild/tree/b4c7fb99e81ff20e92c4bcf42a657d569d1206d0 because Python 3.9 has been deleted:
Then after removing the block from the clean up file above the test passes in https://github.com/artefactual-labs/am-packbuild/tree/32b3184a92f99c37228b64be2509987238e82a14.
I also split the workflow into two jobs, one for building the base image and one for building, testing and publishing the AM box image. This saves time if the AM box build fails but the base image has been created successfully and the workflow needs to be retried.
Connected to archivematica/Issues#1720