My Museum Tour search pagination #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachgarwood
commented
Sep 19, 2024
src/hooks/useFetch.jsx
Outdated
| paginationSelector, | ||
| paginationSetter, | ||
| fetchingSetter, | ||
| errorSetter, |
There was a problem hiding this comment.
I'm not entirely sure why these setters need to be passed in when they are also created above via useState:
const [pagination, setPagination] = useState(null);There was a problem hiding this comment.
I'm not sure what the original reason was for implementing useFetch this way, but it was interfering with testing, so I made useFetch retrieve state directly from the SearchContext.
... to include pagination selector and setter
zachgarwood
commented
Sep 20, 2024
zachgarwood
force-pushed
the
feature/paginate-search-results
branch
from
580364b to
f364ff6
Compare
This is used to navigate the possibly multiple pages of results.
zachgarwood
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.