Develop -> Main #25
Merged
Develop -> Main #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-186172034 Add and remove items from a tour
Unless we decide to use CSS later then re-renders will destroy the state
This was to avoid re-renders triggering fetch
Frankly I'm finding I need to convert it to an array so often It defeats the point of using it at this stage
This was way harder than i'd imagined
also I think aria-pressed makes current state clearer
The 2nd button would need to re-assign focus and it was less clear where
…s-186171954 Preview tour items
Don't see value in using the type without a delay for the larger values
Bug was with the if statement, but change to cat_ids as it was proivded
…86763291 Combined snags
…nter-186832820 Artwork slot counter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIG PR after the final demo (contains everything for the builder)