WIP: Welcome: Standardize usage of 'Cell' ViewModels #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
exhibitions/src/main/kotlin/edu/artic/exhibitions/AllExhibitionsFragment.kt
Outdated
Show resolved
Hide resolved
caguilar187
suggested changes
Oct 19, 2018
| */ | ||
| class AllToursCellViewModel( | ||
| class TourCellViewModel( |
There was a problem hiding this comment.
let's move these into their own files now that they are being used in both places
exhibitions/src/main/kotlin/edu/artic/exhibitions/AllExhibitionsFragment.kt
Outdated
Show resolved
Hide resolved
Cliabhach
changed the title
Cliabhach
force-pushed
the
pc-standardize-usage-of-cell-view-models
branch
4 times, most recently
from
fdbc067 to
5dc9f28
Compare
Cliabhach
force-pushed
the
pc-standardize-usage-of-cell-view-models
branch
from
5dc9f28 to
1144683
Compare
… `all` This removes a decent amount of code duplication.
….kt files I don't know why this wasn't caught earlier? Must've not been reviewed properly.
With this, all of the local variables in the `decoration` package are immutable.
Cliabhach
force-pushed
the
pc-standardize-usage-of-cell-view-models
branch
from
1144683 to
e4eead8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly just removes some duplicate code. There's also some better documentation of the various
Allfragments.This PR is on hold until #297 and #299 are merged in. It will need some relatively-trivial updates after that point to account for moved and deleted files.