Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SuspendApp to the main repo #3577

Merged
merged 8 commits into from
Feb 11, 2025
Merged

Add SuspendApp to the main repo #3577

merged 8 commits into from
Feb 11, 2025

Conversation

serras
Copy link
Member

@serras serras commented Feb 7, 2025

Note: this PR is based on #3576, so if this is merged the other should be closed.

This PR brings https://github.com/arrow-kt/suspendapp to the main Arrow repo (so we can say we have a monorepo now).

In addition, it updates the implementation in suspendapp-ktor to use a Multiplatform equivalent of getting the current directory (based on the same code in ktor-server-core).

@serras serras requested a review from nomisRev February 7, 2025 11:47
@serras serras force-pushed the serras/add-suspendapp branch from 6286f0b to abe2f61 Compare February 7, 2025 12:11
@serras serras force-pushed the serras/add-suspendapp branch from abe2f61 to b0e6e33 Compare February 7, 2025 12:54
@serras serras force-pushed the serras/add-suspendapp branch from b0e6e33 to 1962cdf Compare February 7, 2025 13:28
@serras serras force-pushed the serras/add-suspendapp branch from 1962cdf to e737c73 Compare February 7, 2025 14:16
@serras serras mentioned this pull request Feb 7, 2025
@nomisRev
Copy link
Member

Hey @serras,

I am still ironing out some issues in SuspendApp, so this might be slightly premature.

@serras
Copy link
Member Author

serras commented Feb 11, 2025

Note: @nomisRev and I have agreed to merge this and move all the issues from SuspendApp into the this repo

@serras serras merged commit 9eb68c7 into main Feb 11, 2025
12 checks passed
@serras serras deleted the serras/add-suspendapp branch February 11, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants