-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SuspendApp to the main repo #3577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6286f0b
to
abe2f61
Compare
abe2f61
to
b0e6e33
Compare
b0e6e33
to
1962cdf
Compare
1962cdf
to
e737c73
Compare
Kover Report
|
Closed
Hey @serras, I am still ironing out some issues in SuspendApp, so this might be slightly premature. |
Note: @nomisRev and I have agreed to merge this and move all the issues from SuspendApp into the this repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR is based on #3576, so if this is merged the other should be closed.
This PR brings https://github.com/arrow-kt/suspendapp to the main Arrow repo (so we can say we have a monorepo now).
In addition, it updates the implementation in
suspendapp-ktor
to use a Multiplatform equivalent of getting the current directory (based on the same code inktor-server-core
).