-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Golang & GHAs #92
Conversation
838730e
to
62aec0c
Compare
Seems you have removed the matrix test, which was important as we have had issues where tests failed on one specific OS before. Version not so much but it's nice to have |
35baa17
to
1076d91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question
@brenank This seems to be the manifests file it uses: https://github.com/actions/go-versions/blob/main/versions-manifest.json |
Should work that's there. (As per the The latest 14 is:
So let's try that. I suspect something is wrong with the action. I feel like these should be working. |
19cbcc1
to
0836757
Compare
0836757
to
a13cdaa
Compare
c1109e9
to
717fff0
Compare
717fff0
to
022aeb0
Compare
022aeb0
to
909bd3b
Compare
Interesting! I wonder what that case would be. Alright made some adjustments based of the feedback. Learned a bit about supporting older versions of go, and dropped the go.mod/package changes. The reason the build was failing was github recently introduced |
Thanks. Great detective work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I bet you macos-13
breaks again at some point in the future. Will probably have to consider adding a if step. I will have to add more to the contributing.md file at some point. Partial contents can be misleading
No description provided.