Use set admin port for compatibility to arquillian cube. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aslakknutsen @bartoszmajsak No chance to merge this PR? |
bartoszmajsak
requested changes
Sep 4, 2018
| @@ -241,6 +244,7 @@ public int getAdminListenPort() { | |||
| * The port of the admin server. This is optional. It can be derived from the adminUrl. | |||
| */ | |||
| public void setAdminListenPort(int adminListenPort) { | |||
| this.adminListenPortSet = true; | |||
| this.adminListenPort = adminListenPort; | |||
There was a problem hiding this comment.
Alternatively we could use Integer and rely on it being null instead. WDYT?
| @@ -114,7 +115,9 @@ public void validate() throws ConfigurationException { | |||
| URI adminURI = new URI(adminUrl); | |||
| adminProtocol = adminURI.getScheme(); | |||
| adminListenAddress = adminURI.getHost(); | |||
| adminListenPort = adminURI.getPort(); | |||
| if(!adminListenPortSet) { | |||
There was a problem hiding this comment.
Please fix formatting - if (...).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Now it is possible to use this container adapter together with arquillian-cube-openshift.
Because arquillian-cube-openshift uses openshift port forwarding. But the local port is created randomly. With this change the randomly generated local port is used.