track parent command's attributes with local override #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… option value while allowing local override
|
Turns out I was wrong about what was needed for this. This is now based solely off of master. |
…n up code * creating the inherited option value generator as a builder provides an actual name for the method, which allows it to be overloaded * the factory for the builder method is now in its own routine rather than in the midst of other code * the code has been reformatted to hopefully match that of the project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is based off of my subcommand branch, as it requires access to the parent command.)
This commit provides the ability for a sub-command to track the value of a parent's option and override it locally. For example, if the app has a
verboseoption, and the sub-command also has averboseoption with theinheritattribute set,results in subcommand's
verboseoption equal to 3 whilesets subcommand's
verboseoption to 20.There's no documentation yet; the classes in
t/inherit.tillustrate the concept.It can easily be updated to incorporate a future metadata API.