Cleanup #13
Open
Cleanup #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebased on current master. |
'around' modifiers for _osprey_config, _osprey_options, _osprey_subcommands need only be applied once for each command class. this removes the need for a separate subroutine to apply the modifiers.
…::Osprey::Role The CLI::Osprey::Role is already getting applied to the command class, so the application of the _osprey_options, _osprey_config, and _osprey_subcommands methods can done more naturally there instead of in an eval() in CLI::Osprey::import.
|
mistakenly pushed version which wasn't based on upstream's master, but upon my test-roles branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This streamlines a few issues. The major changes are:
OspreytoOsprey::Roleoptionorsubcommandwas called. They should only need to be run once when the command class is constructed.