Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip google registry check #590

Merged
merged 1 commit into from
Jan 20, 2025
Merged

skip google registry check #590

merged 1 commit into from
Jan 20, 2025

Conversation

refaelm92
Copy link
Contributor

@refaelm92 refaelm92 commented Jan 20, 2025

User description

Signed-off-by: refaelm [email protected]


PR Type

Bug fix


Description

  • Commented out Google registry configuration in the registry connectors.

  • Prevents Google registry checks from being executed.


Changes walkthrough 📝

Relevant files
Bug fix
registry_connectors.py
Disable Google registry configuration in connectors           

tests_scripts/registry/registry_connectors.py

  • Commented out the configuration for Google registry.
  • Removed Google registry from active checks.
  • +5/-5     

    Need help?
  • Type /help how to ... in the comments thread for any question about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Change

    Disabling Google registry checks could impact test coverage. Verify this is intentional and won't affect test scenarios that rely on Google registry validation.

    # {
    #     "provider": "google",
    #     "secret_field_name": "key",
    #     "secret_value_env_var": "GOOGLE_REGISTRY_KEY",
    # },

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Use feature flag instead commenting

    Instead of commenting out the Google registry configuration, consider using a
    feature flag or environment variable to conditionally enable/disable registry
    checks. This maintains code clarity and allows for easier testing.

    tests_scripts/registry/registry_connectors.py [25-29]

    -# {
    -#     "provider": "google",
    -#     "secret_field_name": "key",
    -#     "secret_value_env_var": "GOOGLE_REGISTRY_KEY",
    -# },
    +{
    +    "provider": "google",
    +    "secret_field_name": "key",
    +    "secret_value_env_var": "GOOGLE_REGISTRY_KEY",
    +    "enabled": os.getenv("ENABLE_GOOGLE_REGISTRY", "false").lower() == "true"
    +},
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: Using a feature flag provides better maintainability and flexibility compared to commented code, allowing runtime control of registry availability without code changes. The suggestion is well-structured and includes proper environment variable handling.

    7

    Copy link

    Failed to generate code suggestions for PR

    @refaelm92 refaelm92 merged commit 85b56c6 into master Jan 20, 2025
    2 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants