feat(async-stripe-core): Create newtype for idempotency key #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlyon
approved these changes
Feb 19, 2025
|
CI approved, you may need to rebase this however |
idempotency key cannot be empty and cannot be longer than 255 characters and having asserts before their usage is not the best error handling strategy. having it in a newtype guarantees that every use of this key is valid and no assert or runtime panic is needed. Refs: arlyon#662 (comment) Refs: arlyon#662 (comment) Refs: https://docs.stripe.com/api/idempotent_requests Signed-off-by: Robin Ilyk <[email protected]>
robko23
force-pushed
the
req_strategy_newtype
branch
from
52c3f04 to
7058333
Compare
|
@arlyon @mzeitlin11 rebased on 4dbe007 and fixed the lint about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idempotency key cannot be empty and cannot be longer than 255 characters and having asserts before their usage is not the best error handling strategy. having it in a newtype guarantees that every use of this key is valid and no assert or runtime panic is needed.
Refs: #662 (comment)
Refs: #662 (comment)
Refs: https://docs.stripe.com/api/idempotent_requests