Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(next): enum serialization #605

Merged
merged 2 commits into from
Sep 3, 2024
Merged

fix(next): enum serialization #605

merged 2 commits into from
Sep 3, 2024

Conversation

lasantosr
Copy link

Summary

This pull request closes #604 by properly generating enums.

Checklist

mzeitlin11
mzeitlin11 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@mzeitlin11 mzeitlin11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @lasantosr, just one small comment!

@mzeitlin11 mzeitlin11 merged commit 0306091 into arlyon:next Sep 3, 2024
15 checks passed
@mzeitlin11
Copy link
Collaborator

Thanks @lasantosr - both for testing and fixing issues with the next branch!

@mzeitlin11 mzeitlin11 mentioned this pull request Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzeitlin11 mzeitlin11 mzeitlin11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lasantosr @mzeitlin11